pdf/christmas
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Avoid saving product data if nothing was returned (#101)

Browse source 
* fix: Check if productData is set first

Throughout my testing and debugging, it was possible for productData to
be "undefined". To prevent errors, it's best to check for it's existence
first.

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

* fix: avoid saving wishlist when there's no change

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

---------

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>
This commit is contained in:
Frostyfrog 2023-11-25 19:37:15 -07:00 committed by GitHub
parent b3146d339f
commit d633e90874
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/structures/Wishlist.js
View file

@ -161,6 +161,8 @@ class Wishlist {
} }
const productData = await getProductData(item.url) const productData = await getProductData(item.url)
if (!productData) return; // short-circuit when there's no data
for (const key of ['name', 'price', 'image']) { for (const key of ['name', 'price', 'image']) {
if (productData[key]) item[key] = productData[key] if (productData[key]) item[key] = productData[key]
} }